Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yes, it's bytes #4311

Merged
merged 1 commit into from Oct 29, 2020
Merged

Yes, it's bytes #4311

merged 1 commit into from Oct 29, 2020

Conversation

martinthomson
Copy link
Member

Closes #4303.

@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Oct 29, 2020
marten-seemann
marten-seemann approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧐

@larseggert
Copy link
Member

Does this win the record for least amount of bytes touched in a PR?

@janaiyengar janaiyengar merged commit 656f395 into master Oct 29, 2020
@janaiyengar janaiyengar deleted the issue4303 branch October 29, 2020 23:46
@martinthomson
Copy link
Member Author

Lars, I can't find it easily, but I believe that I pushed a 1 bit change at one point in this process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

@MikeBishop MikeBishop MikeBishop approved these changes

@janaiyengar janaiyengar janaiyengar approved these changes

@ianswett ianswett ianswett approved these changes

@nibanks nibanks nibanks approved these changes

Assignees
No one assigned
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Presumably the length in bytes
7 participants
@martinthomson @larseggert @marten-seemann @MikeBishop @janaiyengar @ianswett @nibanks